Conversation
jzeferino
reviewed
Mar 2, 2018
Member
jzeferino
left a comment
jzeferino
left a comment
There was a problem hiding this comment.
I don't have the time to fully review and test PR this weekend, but will do it ASAP.
jzeferino
requested changes
Mar 8, 2018
| override fun doOnCreated() { | ||
| findViewById<View>(R.id.btnDismiss)!!.setOnClickListener({ dismiss() }) | ||
| } | ||
|
|
| } | ||
|
|
||
| override fun onStopRequestUpdate() { | ||
|
|
Member
There was a problem hiding this comment.
For consistency this method should have comment, has the others.
| } | ||
|
|
||
| override fun onStopRequestUpdate() { | ||
|
|
Member
There was a problem hiding this comment.
For consistency this method should have comment, has the others.
| disable 'InvalidPackage' | ||
| } | ||
| } | ||
|
|
|
|
||
| val btnAnalyticsSendEvent = findViewById<Button>(R.id.btnAnalyticsSendEvent) | ||
| btnAnalyticsSendEvent!!.setOnClickListener { | ||
| /* |
| } | ||
|
|
||
| override fun onStopRequestUpdate() { | ||
|
|
| when (locationError) { | ||
| LocationError.DISABLED -> mTxtInfoUpdates!!.text = "Error: Location disabled" | ||
| LocationError.TIMEOUT -> mTxtInfoUpdates!!.text = "Error: Timeout getting location" | ||
| else -> { |
| fun setOnErrorClickListener(listener: View.OnClickListener) { | ||
| mListener = listener | ||
| } | ||
|
|
| mRclItems!!.visibility = View.VISIBLE | ||
| mBtnTryAgain!!.visibility = View.GONE | ||
| mTxtMessage!!.visibility = View.GONE | ||
|
|
| override fun doOnCreated() { | ||
| activity!!.setTitle(R.string.sample_utils) | ||
|
|
||
| mBtnCheckPlayServicesExists = findViewById(R.id.btnCheckPlayservicesExists) |
Member
There was a problem hiding this comment.
maybe join the lines that has findViewById
Member
|
@extmkv would like to hear your opinion on this since Im not fluent with the language. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was challenged by @NunoSSilva to create an kotlin sample for adal, so here it is. I add kotlin examples to readmes too.