Skip to content

Feature/geofencing#120

Open
PedroOkawa wants to merge 2 commits intodevelopfrom
feature/geofencing
Open

Feature/geofencing#120
PedroOkawa wants to merge 2 commits intodevelopfrom
feature/geofencing

Conversation

@PedroOkawa
Copy link
Copy Markdown
Contributor

Fixed adal-location package (#119) and created Abstract class used to implemente Geofence BroadcastReceiver.

@PedroOkawa PedroOkawa changed the base branch from master to develop July 28, 2017 15:04
@PedroOkawa
Copy link
Copy Markdown
Contributor Author

@jzeferino , can you double check this pull request and new feature?

Copy link
Copy Markdown
Member

@jzeferino jzeferino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

@jzeferino
Copy link
Copy Markdown
Member

@PedroOkawa The PR LGTM.
Please add a sample with the geofencing usage in the the samples.

@PedroOkawa
Copy link
Copy Markdown
Contributor Author

@jzeferino will do it as soon as possible. It's on the plans, but it's necessary to implement a new geofancing from scratch.

@jzeferino
Copy link
Copy Markdown
Member

@PedroOkawa I guess @NunoSSilva can help with it since he was working with geofencing for a while.

@NunoSSilva
Copy link
Copy Markdown
Contributor

First off all we need to update Google Play Services to the latest version because the Geofencing has a new implementation. I can change it when I can

@jzeferino
Copy link
Copy Markdown
Member

@NunoSSilva @PedroOkawa can you guys do something about this?

1 similar comment
@jzeferino
Copy link
Copy Markdown
Member

@NunoSSilva @PedroOkawa can you guys do something about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants