upload benchmarks_generated.js for releases as part of the release workflow

[xabbu42]

This hopefully fixes #861.

I'm not sure how to test workflows locally so this is as yet untested.

• Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
• Briefly describe the changes in this PR.

[github-actions]

Bundle size report:

Size Change: 0 B
Total Size Before: 194 kB
Total Size After: 194 kB

Output file	Before	After	Change
maplibre-gl.js	184 kB	184 kB	0 B
maplibre-gl.css	9.5 kB	9.5 kB	0 B

ℹ️ View Details

No major changes

[HarelM]

You can test this by adding a manual trigger to the upload benchmark yml, this way you can test that the latest is being uploaded.
Once this is working, we'll know that the only problem can be with the tags.

[HarelM]

This is good, please see my comment about adding a manual trigger.

[xabbu42]

I'm quite sure upload-benchmarks.yml is ok, as I only remove steps which where never run anyway. I'm a little bit less sure about the release workflow. I don't want to accidentally do a release :-)

[HarelM]

You can create a pre release maybe?
In any case, we can check it in our next release...

[xabbu42]

Ok, thanks for the review. I'll check if it worked after the next release.

[birkskyum]

@xabbu42 This is the output we got from the release workflow.

[xabbu42]

seems to have worked ok, the only small issue I see is that we now have 2 commits against gh-pages with the exact same commit message "deploy: f47e53c". we should change the commit message for the release workflow to something like "deploy: v2.1.1".

[birkskyum]

good idea.

Are these warnings about missing directory and path irrelevant?

[xabbu42]

also I forgot to set BENCHMARK_VERSION, so it says "main f47e53c" instead of "v2.1.1".

[xabbu42]

I don't know. Perhaps I can look into it tomorrow.

[xabbu42]

The warnings about missing directory are a problem with the action we use and can safely be ignored. I opened a pull request to avoid it: peaceiris/actions-gh-pages#698