Guard mailbox fetch against missing rows#7195
Draft
onyangodonomondi wants to merge 1 commit intomailcow:masterfrom
Draft
Guard mailbox fetch against missing rows#7195onyangodonomondi wants to merge 1 commit intomailcow:masterfrom
onyangodonomondi wants to merge 1 commit intomailcow:masterfrom
Conversation
Collaborator
1 similar comment
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR include?
Short Description
This PR adds a guard in
data/web/inc/functions.mailbox.inc.phpso the mailbox details lookup returnsfalsewhen no database row is found.Without this check, the code can continue accessing
$row[...]after an empty query result, which risks warnings or follow-on failures for invalid or missing mailbox lookups.Affected Containers
Did you run tests?
What did you tested?
php -linsidephp-fpm-mailcowfordata/web/inc/functions.mailbox.inc.phpdemo@demo.localhostHTTP 200 OKWhat were the final results? (Awaited, got)
Awaited:
Got:
demo@demo.localhost{}cleanly formissing-mailbox-check@mail.localhost