[Backup] Return error when mariabackup or other backup steps fail#7159
Open
EzxD wants to merge 1 commit intomailcow:stagingfrom
Open
[Backup] Return error when mariabackup or other backup steps fail#7159EzxD wants to merge 1 commit intomailcow:stagingfrom
EzxD wants to merge 1 commit intomailcow:stagingfrom
Conversation
Fixes mailcow#7144: backup_and_restore.sh exited with code 0 even when mariabackup failed, producing broken backups silently. - Change mariabackup command chain from ; to && so failures stop the pipeline instead of continuing to tar a broken backup - Track exit codes for all backup steps (vmail, crypt, redis, rspamd, postfix, mysql) and report failures - Exit with code 1 if any backup step failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
What does this PR include?
Short Description
Fixes #7144.
backup_and_restore.shexits with code 0 even whenmariabackupfails, producing broken backups silently.Two problems:
docker runare chained with;(semicolons), so--prepare,chown, andtarall run even after--backupfails — creating a broken archive that looks valid.docker runbackup commands have their exit codes checked.This PR changes the mariabackup chain from
;to&&and adds exit code checks for all backup steps. The script now exits with code 1 if any step failed.Affected Containers
None — this only changes the host-side helper script
helper-scripts/backup_and_restore.sh.Did you run tests?
What did you tested?
Verified the shell logic that causes the bug:
Also ran
bash -nsyntax check on the modified script.What were the final results? (Awaited, got)
With
&&, the command chain stops at the first failure and propagates a non-zero exit code. The error tracking logic then catches it and exits the script with code 1. This matches the expected behavior described in #7144.