Skip to content

ENH: using sklearn.utils for creating RNGs and generating minibatches#101

Open
dohmatob wants to merge 1 commit intomaciejkula:masterfrom
dohmatob:sklearn-utils
Open

ENH: using sklearn.utils for creating RNGs and generating minibatches#101
dohmatob wants to merge 1 commit intomaciejkula:masterfrom
dohmatob:sklearn-utils

Conversation

@dohmatob
Copy link
Copy Markdown

Spotlight already depends on scikit learn (sklearn), so we could delegate even more stuff to the later.

@dohmatob dohmatob changed the title ENH: using sklearn.utils for create RNGs and generating minibatches ENH: using sklearn.utils for creating RNGs and generating minibatches Mar 13, 2018
@maciejkula
Copy link
Copy Markdown
Owner

Looks good, thanks for the contribution!

Could you fix the flake8 issue please?

@dohmatob
Copy link
Copy Markdown
Author

Fixed the flake issue. Now there is a mystical failure which seems to be affecting other open PRs too.

UnsatisfiableError: The following specifications were found to be in conflict:
  - chardet -> python[version='>=3.6,<3.7.0a0']
  - python=2.7
Use "conda info <package>" to see the dependencies for each package.

@maciejkula
Copy link
Copy Markdown
Owner

Yes, the dependencies seem to have moved in an annoying way. I'll do my best to resolve this.

@maciejkula
Copy link
Copy Markdown
Owner

Could you please rebase on top of newest master?

@maciejkula
Copy link
Copy Markdown
Owner

Can you rebase please? Otherwise I'll close this and re-open the PR with rebased code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants