refactor(firmware): route account and app_center URLs through secret_logic#20
Open
Flo5k5 wants to merge 1 commit intom5stack:mainfrom
Open
refactor(firmware): route account and app_center URLs through secret_logic#20Flo5k5 wants to merge 1 commit intom5stack:mainfrom
Flo5k5 wants to merge 1 commit intom5stack:mainfrom
Conversation
…logic Align hal_account.cpp and hal_app_center.cpp with hal_ws_avatar.cpp:66, which already builds the StackChan server URL by composing secret_logic::get_server_url() with the route path. Before this change, the four remaining HTTP endpoints were hard-coded to the production IP (http://47.113.125.164:12800), preventing custom server-url overrides from taking effect on three of the four services. Now all four HAL call sites go through the same weak-linked secret_logic::get_server_url() extension point. No functional change intended: the default return of get_server_url() still resolves to the server URL configured at build time via the secret_logic override (or the stub localhost:3000 when no override is provided).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align hal_account.cpp and hal_app_center.cpp with hal_ws_avatar.cpp:66,
which already builds the StackChan server URL by composing
secret_logic::get_server_url() with the route path.
Before this change, the four remaining HTTP endpoints were hard-coded to
the production IP (http://47.113.125.164:12800), preventing custom
server-url overrides from taking effect on three of the four services.
Now all four HAL call sites go through the same weak-linked
secret_logic::get_server_url() extension point.
No functional change intended: the default return of get_server_url()
still resolves to the server URL configured at build time via the
secret_logic override (or the stub localhost:3000 when no override is
provided).