fix(server): use relative SQLite path so dev mode works without root#18
Open
Flo5k5 wants to merge 1 commit intom5stack:mainfrom
Open
fix(server): use relative SQLite path so dev mode works without root#18Flo5k5 wants to merge 1 commit intom5stack:mainfrom
Flo5k5 wants to merge 1 commit intom5stack:mainfrom
Conversation
The config.yaml shipped in the repo points the SQLite link at /stackChan.sqlite (filesystem root). That works in the provided Alpine Dockerfile, which sets WORKDIR=/app and runs as root, but it prevents any non-root developer from starting ./StackChan locally: GoFrame fails to open the DB file on boot because / is not writable. Switching to ./stackChan.sqlite resolves to WORKDIR in both situations (local go run / go build and the Docker container), so the stock command "go build && ./StackChan" finally works out of the box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config.yaml shipped in the repo points the SQLite link at
/stackChan.sqlite (filesystem root). That works in the provided Alpine
Dockerfile, which sets WORKDIR=/app and runs as root, but it prevents
any non-root developer from starting ./StackChan locally: GoFrame fails
to open the DB file on boot because / is not writable.
Switching to ./stackChan.sqlite resolves to WORKDIR in both situations
(local go run / go build and the Docker container), so the stock
command "go build && ./StackChan" finally works out of the box.