Upgrade to Go 1.25 and golangci-lint v2

.github/workflows/lint.yml

@@ -11,10 +11,10 @@ jobs:
     steps:
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.24
+          go-version: 1.25
       - uses: actions/checkout@v3
       - name: Run golangci-lint
         uses: golangci/golangci-lint-action@v3.2.0
         with:
           args: --timeout 3m --verbose --disable revive
-          version: v1.64.5
+          version: v2.4.0

.github/workflows/test.yml

@@ -24,6 +24,6 @@ jobs:
             && sudo cp conftest /usr/local/bin/conftest
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.24
+          go-version: 1.25
       - uses: actions/checkout@v3
       - run: make test-all

.golangci.yml

@@ -1,38 +1,45 @@
+version: "2"
 linters:
   enable:
-    - errcheck
+    - dogsled
+    - dupword
     - gochecknoinits
-    # We don't use goconst because it gives false positives in the tests.
-    #  - goconst
-    - gofmt
-    # We don't use revive because it gives false positives in the tests.
-    #  - revive
     - gosec
-    - gosimple
-    - ineffassign
-    - staticcheck
-    - typecheck
+    - interfacebloat
     - unconvert
-    - unused
-    - vet
-    - vetshadow
-    - dogsled
-    - dupword
     - unparam
-    - interfacebloat
     - usestdlibvars
     - whitespace
-issues:
-  exclude-rules:
-    - path: server/legacy/controllers/events/events_controller(.+)test.go
-      linters:
-        - dogsled
-    - path: server/legacy/events/event_parser_test.go
-      linters:
-        - dogsled
-    - path: server/legacy/events/command_runner_test.go
-      linters:
-        - dogsled
-linters-settings:
-  interfacebloat:
-    max: 7
+  settings:
+    interfacebloat:
+      max: 7
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - dogsled
+        path: server/legacy/controllers/events/events_controller(.+)test.go
+      - linters:
+          - dogsled
+        path: server/legacy/events/event_parser_test.go
+      - linters:
+          - dogsled
+        path: server/legacy/events/command_runner_test.go
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

go.mod

@@ -1,6 +1,6 @@
 module github.com/runatlantis/atlantis
 
-go 1.24
+go 1.25
 
 replace google.golang.org/grpc => google.golang.org/grpc v1.45.0