-
Notifications
You must be signed in to change notification settings - Fork 8
Add ORFS Integration test #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
luarss
wants to merge
7
commits into
main
Choose a base branch
from
integration-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
faeccbf
Add integration tests for ORFS flows via MCP protocol
luarss 08e0507
Mark integration tests as complete in roadmap
luarss 948ecf4
refactor client session into fixtures
luarss c0b27f9
allow startup output to drain
luarss 96c3a40
unskip tests
luarss 71441ea
increase test-performance threshold
luarss 2c5b2ed
fix: address PR #37 review comments
luarss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,44 @@ | ||
| """Pytest configuration for integration tests without mocks.""" | ||
|
|
||
| import asyncio | ||
| import os | ||
| from collections.abc import AsyncGenerator | ||
| from contextlib import asynccontextmanager | ||
|
|
||
| import pytest | ||
| import pytest_asyncio | ||
| from mcp import ClientSession, StdioServerParameters | ||
| from mcp.client.stdio import stdio_client | ||
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def event_loop(): | ||
| """Create an event loop for the test session.""" | ||
| loop = asyncio.new_event_loop() | ||
| yield loop | ||
| loop.close() | ||
|
|
||
|
|
||
| @pytest_asyncio.fixture(scope="function") | ||
| async def mcp_client() -> AsyncGenerator[ClientSession]: | ||
| """Fixture providing a MCP client session.""" | ||
| server_params = StdioServerParameters(command="python", args=["-m", "openroad_mcp.main"], env=None) | ||
|
|
||
| @asynccontextmanager | ||
| async def _mcp_session(server_params: StdioServerParameters): | ||
| """Shared async context manager for MCP client sessions with cancel-scope guard.""" | ||
| try: | ||
| async with stdio_client(server_params) as (read, write): | ||
| async with ClientSession(read, write) as session: | ||
| await session.initialize() | ||
| await asyncio.sleep(1.0) | ||
| yield session | ||
| except RuntimeError as e: | ||
| if "cancel scope" in str(e): | ||
| # Skip teardown exception (openroad-mcp handles their own teardown) | ||
| # anyio emits a RuntimeError on cancel-scope teardown when the MCP | ||
| # server subprocess exits | ||
| if "cancel scope" in str(e).lower(): | ||
| pass | ||
| else: | ||
| raise | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
|
|
||
| @pytest_asyncio.fixture(scope="function") | ||
| async def mcp_client() -> AsyncGenerator[ClientSession]: | ||
| """Fixture providing a MCP client session.""" | ||
| server_params = StdioServerParameters( | ||
| command="python", | ||
| args=["-m", "openroad_mcp.main"], | ||
| env={ | ||
| **os.environ, | ||
| "OPENROAD_ENABLE_COMMAND_VALIDATION": "false", | ||
| }, | ||
| ) | ||
|
|
||
| async with _mcp_session(server_params) as session: | ||
| yield session | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.