Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-4996-resetfield-undefined.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"vee-validate": patch
---

Fix resetField({ value: undefined }) preventing form from becoming valid (#4996)
3 changes: 3 additions & 0 deletions packages/vee-validate/src/useForm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -779,6 +779,7 @@ export function useForm<
const pathState = findPathState(field);
if (pathState) {
pathState.__flags.pendingReset = true;
pathState.validated = false;
}

setFieldInitialValue(field, deepCopy(newValue), true);
Expand All @@ -790,6 +791,8 @@ export function useForm<
if (pathState) {
pathState.__flags.pendingReset = false;
}

validateField(field, { mode: 'silent' });
});
}

Expand Down
50 changes: 50 additions & 0 deletions packages/vee-validate/tests/useForm.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1489,4 +1489,54 @@
form.setValues({ file: f2 });
expect(form.values.file).toEqual(f2);
});

// #4996
test('resetField with undefined value should not prevent form from becoming valid', async () => {
let form!: FormContext<{ name: string }>;

mountWithHoc({
setup() {
form = useForm({
validationSchema: z.object({
name: z.string().min(1),
}),
});

form.defineField('name');

return {};
},
template: `
<div></div>
`,
});

await flushPromises();

// Fill in a valid value and validate
form.setFieldValue('name', 'John');
await flushPromises();

const pending1 = form.validate();
await flushPromises();
const result1 = await pending1;
expect(result1.valid).toBe(true);
expect(form.meta.value.valid).toBe(true);

// Reset field with undefined value using form-level resetField
form.resetField('name', { value: undefined });
await flushPromises();

// After reset, validated should be false so that subsequent validation works correctly
const pathState = form.getPathState('name');

Check failure on line 1531 in packages/vee-validate/tests/useForm.spec.ts

View workflow job for this annotation

GitHub Actions / typecheck

Property 'getPathState' does not exist on type 'FormContext<{ name: string; }, { name: string; }>'.
expect(pathState?.validated).toBe(false);

// Now fill in a valid value again
form.setFieldValue('name', 'Jane');
await flushPromises();

// The form should be valid again
expect(form.meta.value.valid).toBe(true);
expect(form.errors.value.name).toBeUndefined();
});
});
Loading