Fix Docker Desktop detection via ~/.docker/run/docker.sock#206
Merged
carole-lavillonniere merged 1 commit intomainfrom Apr 27, 2026
Merged
Conversation
Docker Desktop on macOS uses ~/.docker/run/docker.sock when the /var/run/docker.sock symlink is absent. Extract vmSocketPaths() as single source of truth for findDockerSocket() and isVM(); fixes Lima host socket missing from isVM(). Closes DRG-754
carole-lavillonniere
requested review from
anisaoshafi and
silv-io
as code owners
carole-lavillonniere
deleted the
drg-754-probe-dockerrundockersock-for-docker-availability
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Docker Desktop on macOS uses
~/.docker/run/docker.sockwhen the/var/run/docker.socksymlink is absent. lstk only probed the standard path, causing false "Docker is not available" errors even with Docker Desktop running.Changes
~/.docker/run/docker.sockto the socket probe list infindDockerSocket()vmSocketPaths()as single source of truth used by bothfindDockerSocket()andisVM()— previously two separate lists that could drift~/.lima/docker/sock/docker.sock) toisVM(), which was missing: containers bind-mount/var/run/docker.sockregardless of the host-side socket pathTests
Unit tests cover all VM socket paths for both discovery (
findDockerSocket) and bind-mount path remapping (isVM/SocketPath).Closes DRG-754