Reusable Realtime Session across Handoffs & Agent Tasks

[toubatbrian]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 4b4f251

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages

Name	Type
@livekit/agents-plugin-phonic	Patch
@livekit/agents	Patch
@livekit/agents-plugin-google	Patch
@livekit/agents-plugin-openai	Patch
@livekit/agents-plugin-anam	Patch
@livekit/agents-plugin-baseten	Patch
@livekit/agents-plugin-bey	Patch
@livekit/agents-plugin-cartesia	Patch
@livekit/agents-plugin-deepgram	Patch
@livekit/agents-plugin-elevenlabs	Patch
@livekit/agents-plugin-hedra	Patch
@livekit/agents-plugin-inworld	Patch
@livekit/agents-plugin-lemonslice	Patch
@livekit/agents-plugin-livekit	Patch
@livekit/agents-plugin-neuphonic	Patch
@livekit/agents-plugin-resemble	Patch
@livekit/agents-plugin-rime	Patch
@livekit/agents-plugin-sarvam	Patch
@livekit/agents-plugin-silero	Patch
@livekit/agents-plugins-test	Patch
@livekit/agents-plugin-trugen	Patch
@livekit/agents-plugin-xai	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[chatgpt-codex-connector]

💡 Codex Review

agents-js/agents/src/utils.ts

Lines 960 to 963 in 58726f4

	if (signal) {
	const abortPromise = waitForAbort(signal);
	while (true) {
	const result = await Promise.race([reader.read(), abortPromise]);

Handle pre-aborted signals before entering read loop

readStream races reader.read() against waitForAbort(signal), but waitForAbort only resolves on a future abort event. If the signal is already aborted when readStream starts (which can happen when cancellation wins a task startup race during pause/close), the abort branch never resolves and the generator keeps waiting on stream reads instead of exiting promptly, so cancellation can hang until the source ends.

---

agents-js/agents/src/voice/agent_activity.ts

Lines 829 to 830 in 58726f4

	taskFn: (abortController: AbortController) =>
	this.realtimeSayTask(handle, text, {}, abortController),

Preserve addToChatCtx behavior in realtime say path

The new realtime say branch drops the addToChatCtx option by calling realtimeSayTask without passing it. Unlike the TTS path, realtime generation always inserts an assistant message into chat context, so session.say(..., { addToChatCtx: false }) no longer works for realtime-without-TTS configurations and will unexpectedly mutate conversation history.

---

agents-js/agents/src/stream/deferred_stream.ts

Lines 87 to 89 in 58726f4

	if (this.detachRequested) {
	this.detachRequested = false;
	return;

Make detach state pump-local during source handoff

detachRequested is shared across all pump instances. During rapid detach+reattach, a newly attached pump can reach finally first (for example, if the new source ends immediately), clear this flag, and then the old detached pump will run the normal close path and close the shared writable side. That can terminate the newly attached stream unexpectedly and drop post-handoff audio.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[devin-ai-integration]

Devin Review found 1 new potential issue.

View 17 additional findings in Devin Review.

[devin-ai-integration]

🔴 Floating promise in Phonic generateReply can cause indefinite caller hang

In generateReply(), this.sendGenerateReply(instructions, requestId) at line 486 is called without await, void, or .catch(). The sendGenerateReply method is async and can throw after the await this.readyToStart.await (e.g., if this.socket.sendGenerateReply(...) at line 505 throws because the socket just closed). If this happens, the thrown error becomes an unhandled promise rejection AND this.pendingGenerateReplyFut is never resolved or rejected, causing the caller of generateReply() (which awaits this.pendingGenerateReplyFut.await at line 488) to hang indefinitely.

Prompt for agents

In plugins/phonic/src/realtime/realtime_model.ts, the generateReply method at line 486 calls this.sendGenerateReply(instructions, requestId) without awaiting or catching the returned promise. The sendGenerateReply method is async and can throw after its internal await (e.g. if socket.sendGenerateReply throws). This leaves pendingGenerateReplyFut unresolved, hanging the caller forever.

The fix should wrap the socket send inside sendGenerateReply in a try/catch that rejects pendingGenerateReplyFut on error. Alternatively, the call in generateReply could be changed to something like:

void this.sendGenerateReply(instructions, requestId).catch((error) => {
  if (this.pendingGenerateReplyFut && !this.pendingGenerateReplyFut.done) {
    this.pendingGenerateReplyFut.reject(error);
    this.pendingGenerateReplyFut = undefined;
  }
});

Either approach ensures that if sendGenerateReply fails, pendingGenerateReplyFut is rejected so the caller does not hang indefinitely.

---

Was this helpful? React with 👍 or 👎 to provide feedback.