Skip to content

fix(openai): prevent early channel close causing lost transcripts #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
TanmayChaurasia24 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(openai): prevent early channel close causing lost transcripts #1176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed54621
fix(openai): prevent early channel close causing lost transcripts
TanmayChaurasia24 Mar 25, 2026
e707950
fix(root): remove accidentally added workspace packages from root pac…
TanmayChaurasia24 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions plugins/openai/src/realtime/realtime_model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1504,8 +1504,10 @@ export class RealtimeSession extends llm.RealtimeSession {
return;
}
// text response doesn't have itemGeneration
itemGeneration.textChannel.close();
itemGeneration.audioChannel.close();
// Removed textChannel.close() and audioChannel.close() because
// OpenAI gpt-realtime-1.5 fires output_item.done before transcription completes.
// Channel cleanup is safely handled instead by handleResponseDone.

if (!itemGeneration.modalities.done) {
// In case message modalities is not set, this shouldn't happen
itemGeneration.modalities.resolve(this.oaiRealtimeModel._options.modalities);
Expand Down