Add support for Ripple (WIP) #865
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from './lang-ripple'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,31 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| import type { LanguageSpecs } from '../../models'; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| import { rippleUrl } from '../../vendors'; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| import { parserPlugins } from '../prettier'; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| export const ripple: LanguageSpecs = { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| name: 'ripple', | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| title: 'Ripple', | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| info: false, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| parser: { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| name: 'babel-ts', | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| pluginUrls: [parserPlugins.babel, parserPlugins.html], | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| compiler: { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| factory: async () => { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| // TODO: convert to UMD | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| const { compile } = await import(rippleUrl); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| return async (code) => { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| if (!code.trim()) return ''; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| const { js, css } = await compile(code, './src/App.ripple'); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| const cssCode = | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| css === '' | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| ? '' | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| : `\n\nconst styles = document.createElement('style');\nstyles.innerHTML = ${JSON.stringify(css)};\ndocument.head.appendChild(styles);\n`; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| return `${js.code}${cssCode}`; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| }; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. 🛠️ Refactor suggestion Add compiler.imports, guard imports, and surface compile errors.
compiler: {
- factory: async () => {
+ factory: async () => {
// TODO: convert to UMD
- const { compile } = await import(rippleUrl);
+ const { compile } = await import(rippleUrl);
return async (code) => {
- if (!code.trim()) return '';
- const { js, css } = await compile(code, './src/App.ripple');
+ if (!code.trim()) return "export default () => null;";
+ try {
+ const { js, css } = await compile(code, './src/App.ripple');
const cssCode =
- css === ''
- ? ''
- : `\n\nconst styles = document.createElement('style');\nstyles.innerHTML = ${JSON.stringify(css)};\ndocument.head.appendChild(styles);\n`;
- return `${js.code}${cssCode}`;
+ css === ''
+ ? ''
+ : `\n\n(function(){const id='lc-ripple-style';let s=document.getElementById(id);if(!s){s=document.createElement('style');s.id=id;document.head.appendChild(s);}s.textContent=${JSON.stringify(
+ css,
+ )};})();`;
+ return `${js.code}${cssCode}`;
+ } catch (err) {
+ console.error('[ripple] compile error:', err);
+ throw err;
+ }
};
},
+ imports: { ripple: rippleModuleUrl },
},📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| extensions: ['ripple'], | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| editor: 'script', | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| editorLanguage: 'typescript', | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| }; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,9 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||
| export const rippleRuntime = ` | ||||||||||||||||||||||||||||||||||||||||||||||||||
| import { mount } from 'ripple'; | ||||||||||||||||||||||||||||||||||||||||||||||||||
| import App from "./script"; | ||||||||||||||||||||||||||||||||||||||||||||||||||
| (() => { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| mount(App, { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| target: document.querySelector("#livecodes-app") || document.body.appendChild(document.createElement('div')), | ||||||||||||||||||||||||||||||||||||||||||||||||||
| }); | ||||||||||||||||||||||||||||||||||||||||||||||||||
| })(); | ||||||||||||||||||||||||||||||||||||||||||||||||||
| `; | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+1
to
+9
There was a problem hiding this comment. 💡 Verification agent 🧩 Analysis chainMake runtime resilient to non-default exports from compiled script. If the Ripple compiler doesn’t emit a default export, -export const rippleRuntime = `
-import { mount } from 'ripple';
-import App from "./script";
-(() => {
- mount(App, {
- target: document.querySelector("#livecodes-app") || document.body.appendChild(document.createElement('div')),
- });
-})();
-`;
+export const rippleRuntime = `
+import { mount } from 'ripple';
+import * as AppModule from "./script";
+(() => {
+ const App = AppModule.default || AppModule.App || AppModule;
+ const target =
+ document.querySelector("#livecodes-app") ||
+ (() => { const el = document.createElement('div'); el.id = 'livecodes-app'; return document.body.appendChild(el); })();
+ mount(App, { target });
+})();
+`;🏁 Script executed: #!/bin/bash
# List all files under the Ripple language integration directory
fd src/livecodes/languages/ripple -t f
# Locate any compiler or codegen files in that directory
fd compile src/livecodes/languages/ripple -t f
# Search for default export patterns in the ripple language code
rg -n "export default" src/livecodes/languages/ripple
# Search for named export patterns (const/function/class) in the same directory
rg -n "export (const|function|class) " src/livecodes/languages/rippleLength of output: 812 🏁 Script executed: #!/bin/bash
sed -n '1,200p' src/livecodes/languages/ripple/ripple-runtime.tsLength of output: 308 🏁 Script executed: #!/bin/bash
# Preview the first 200 lines of the Ripple language spec to see how compiled script is generated
sed -n '1,200p' src/livecodes/languages/ripple/lang-ripple.tsLength of output: 1003 Use namespace import with export fallbacks and assign File: src/livecodes/languages/ripple/ripple-runtime.ts -export const rippleRuntime = `
-import { mount } from 'ripple';
-import App from "./script";
-(() => {
- mount(App, {
- target: document.querySelector("#livecodes-app") || document.body.appendChild(document.createElement('div')),
- });
-})();
-`;
+export const rippleRuntime = `
+import { mount } from 'ripple';
+import * as AppModule from "./script";
+(() => {
+ const App = AppModule.default || AppModule.App || AppModule;
+ const target =
+ document.querySelector("#livecodes-app") ||
+ (() => {
+ const el = document.createElement('div');
+ el.id = 'livecodes-app';
+ return document.body.appendChild(el);
+ })();
+ mount(App, { target });
+})();
+`;📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -389,6 +389,8 @@ export const resetCssUrl = /* @__PURE__ */ getUrl('reset-css@5.0.1/reset.css'); | |
|
|
||
| export const riotBaseUrl = /* @__PURE__ */ getUrl('riot@9.2.2/'); | ||
|
|
||
| export const rippleUrl = /* @__PURE__ */ getModuleUrl('ripple@0.2.5/compiler'); | ||
|
There was a problem hiding this comment. 💡 Verification agent 🧩 Analysis chainPin Ripple runtime to the same version as the compiler to avoid skew Compiler is pinned to ripple@0.2.5, but runtime imports resolve "ripple" via generic import maps, which may pull a different version. Add a pinned module URL to use in the Ripple language spec Apply this diff here and reference it from the Ripple language spec: export const riotBaseUrl = /* @__PURE__ */ getUrl('riot@9.2.2/');
-export const rippleUrl = /* @__PURE__ */ getModuleUrl('ripple@0.2.5/compiler');
+export const rippleUrl = /* @__PURE__ */ getModuleUrl('ripple@0.2.5/compiler');
+export const rippleModuleUrl = /* @__PURE__ */ getModuleUrl('ripple@0.2.5');Then, in import { rippleUrl, rippleModuleUrl } from '../../vendors';
compiler: {
factory: async () => { /* unchanged */ },
imports: { ripple: rippleModuleUrl },
},🌐 Web query: 💡 Result: Short answer: No — I couldn't find any evidence that a package named "ripple" at version 0.2.5 exposes an ESM entry "ripple@0.2.5/compiler" that exports a compile function, nor that the documented runtime API is import { mount } from 'ripple'. Evidence:
If you want me to check a specific npm package tarball or the exact contents of ripple@0.2.5 (e.g. via unpkg or npm pack) I can fetch and list the package files to confirm. Citations:
🏁 Script executed: #!/bin/bash
set -e
# List files in ripple@0.2.5 npm package
echo "Listing files in ripple@0.2.5 package..."
curl -sL https://registry.npmjs.org/ripple/-/ripple-0.2.5.tgz | tar -tz > ripple-files.txt
echo -e "\nFiles containing 'compiler':"
grep -R 'compiler' ripple-files.txt || echo "(none found)"
echo -e "\nShowing package.json (first 200 lines):"
curl -sL https://registry.npmjs.org/ripple/-/ripple-0.2.5.tgz | tar -xzO package/package.json | sed -n '1,200p'Length of output: 2560 🏁 Script executed: #!/bin/bash
set -e
# Verify if the compiler entry exports a `compile` function
echo "Checking compiler exports for 'compile':"
curl -sL https://registry.npmjs.org/ripple/-/ripple-0.2.5.tgz \
| tar -xzO package/src/compiler/index.js \
| grep -E "export (async )?function compile|export { compile"
# List all top-level exports in the runtime entry
echo -e "\nListing exports in runtime index:"
curl -sL https://registry.npmjs.org/ripple/-/ripple-0.2.5.tgz \
| tar -xzO package/src/runtime/index.js \
| grep -E "export "
# Search for any `mount` export or usage in the runtime entry
echo -e "\nSearching for 'mount' in runtime index:"
curl -sL https://registry.npmjs.org/ripple/-/ripple-0.2.5.tgz \
| tar -xzO package/src/runtime/index.js \
| grep -R "mount"Length of output: 4193 Pin Ripple runtime URL to v0.2.5 and update Ripple language spec export const rippleUrl = /* @__PURE__ */ getModuleUrl('ripple@0.2.5/compiler');
+export const rippleModuleUrl = /* @__PURE__ */ getModuleUrl('ripple@0.2.5');Then in import { rippleUrl, rippleModuleUrl } from '../../vendors';
compiler: {
factory: async () => { /* unchanged */ },
imports: { ripple: rippleModuleUrl },
},🤖 Prompt for AI Agents |
||
|
|
||
| export const rubyWasmBaseUrl = /* @__PURE__ */ getUrl('@ruby/3.3-wasm-wasi@2.6.2/dist/'); | ||
|
|
||
| export const rubyWasmScriptUrl = /* @__PURE__ */ getUrl( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid empty module when editor content is blank.
Returning
''yields a module with no exports; the runtime import then fails. Emit a tiny no-op component instead.📝 Committable suggestion
🤖 Prompt for AI Agents