Open
Conversation
Also have generator comment out Rails 7.1 health check. See also: * superfly/flyctl#1678 * rails/rails#47217 * rails/rails#46936
Author
|
More background on this request: https://fly.io/ruby-dispatch/health-checks/ |
Owner
|
Hey @rubys , I did some tests using your PR as reference, I thought great the idea but the statement Did you test it in some way? Having it understood, we can move to commit your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background: Rails 7.1 will be adding health checks. I work for Fly.io as a Rails Speciality and would like to make Fly.io automatically detect the presence of health checks and pre-configure applications to enable these health checks if I can detect them. The problem is that health checks can vary on paths and implementation, so I'm proposing the following way to detect checks:
This pull request will add
as: :rails_healh_checkto the route. Additionally the generator will comment out any Rails 7.1 health check that might be present.See also: