feat: add configuration to set an URL parameter#51
feat: add configuration to set an URL parameter#51nicolas-brousse wants to merge 1 commit intolinqueta:masterfrom
Conversation
|
Hey @nicolas-brousse , I think this part of controller is growing with some features that was implemented recently. So, at today night I'll refactor and include your suggestion. Can be by this way? |
|
@linqueta sure 🙂 |
linqueta
left a comment
There was a problem hiding this comment.
I think we can merge it now, so, can you adjust the token condition?
|
Hi @linqueta. What is the issue with the token condition? I'm not sure to understand what you want as changes. |
| return true if Healthcheck.configuration.token.blank? | ||
|
|
||
| Healthcheck.configuration.token == params[:token] |
There was a problem hiding this comment.
Sorry man, I forgot to send this comment.
I just asked about to replace it to:
| return true if Healthcheck.configuration.token.blank? | |
| Healthcheck.configuration.token == params[:token] | |
| Healthcheck.configuration.token.blank? || Healthcheck.configuration.token == params[:token] |
Sorry about my mistake, I forgot to send the comment with the adjust, can you see it now? |
|
@linqueta yes I see it. I'll try to have a look on it this week. Thanks |
This PR add a
tokenconfiguration to add a small protection on URL.