Skip to content
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 84 additions & 0 deletions test/integration/models/linode/test_linode.py
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,16 @@ def instance_type_condition(linode: Instance, type: str):
return type in str(linode.type)


def test_get_linodes_verify_alerts(test_linode_client, create_linode):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create_linode is not used in this test. Probably can be removed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, but we need at least one linode to verify get linodes endpoint. It was suggested by copilot #669 (comment). What do you think about this?

Copy link
Copy Markdown
Contributor

@yec-akamai yec-akamai Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copilot suggests to not use the listing endpoint linode.instance() and use create_linode. I agree that it's safer to not assume there is linode available by listing.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use code fix suggested by Copilot. Should I change it somehow?

linodes_list = test_linode_client.linode.instances().lists[0]
assert len(linodes_list) > 0
assert linodes_list[0].alerts.cpu >= 0
assert linodes_list[0].alerts.io >= 0
assert linodes_list[0].alerts.network_in >= 0
assert linodes_list[0].alerts.network_out >= 0
assert linodes_list[0].alerts.transfer_quota >= 0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not mistaken, values of alerts.cpu, alerts.ip etc. cannot be lower than 0 (e.g. -10) so you can shorten these assertions and just use something like: assert linodes_list[0].alerts.cpu - it will pass when value > 0 and fail when value = 0



Comment on lines +256 to +264
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_get_linodes_verify_alerts is non-deterministic: it creates a Linode via the create_linode fixture but then asserts against instances().lists[0][0], which may be an unrelated instance (ordering/pagination is not guaranteed). To make the test reliable, assert against the specific Linode created by the fixture (e.g., load by create_linode.id or filter the list for that ID), and avoid reaching into the internal .lists cache when plain indexing/iteration works.

Suggested change
linodes_list = test_linode_client.linode.instances().lists[0]
assert len(linodes_list) > 0
assert linodes_list[0].alerts.cpu >= 0
assert linodes_list[0].alerts.io >= 0
assert linodes_list[0].alerts.network_in >= 0
assert linodes_list[0].alerts.network_out >= 0
assert linodes_list[0].alerts.transfer_quota >= 0
linode = test_linode_client.load(Instance, create_linode.id)
assert linode.alerts.cpu >= 0
assert linode.alerts.io >= 0
assert linode.alerts.network_in >= 0
assert linode.alerts.network_out >= 0
assert linode.alerts.transfer_quota >= 0

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would implement extra filtering to find just created linode, but this test is like smoke test and in my opinion we don't need to check specific values. Do you see any benefit of this change?

def test_get_linode(test_linode_client, linode_with_volume_firewall):
linode = test_linode_client.load(Instance, linode_with_volume_firewall.id)

Expand Down Expand Up @@ -283,6 +293,8 @@ def test_linode_rebuild(test_linode_client):

assert linode.status == "rebuilding"
assert linode.image.id == "linode/debian12"
assert linode.alerts.cpu >= 0
assert linode.alerts.io >= 0

assert linode.disk_encryption == InstanceDiskEncryptionType.disabled

Expand Down Expand Up @@ -346,6 +358,78 @@ def test_linode_reboot(create_linode):
assert linode.status == "running"


def test_linode_alerts_workflow(test_linode_client, create_linode):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test case to creat linode with aclp alerts? Adding system_alerts should be good

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, please verify test just added: test_update_linode_aclp_alerts

linode = create_linode
parent_linode_id = create_linode.id
assert linode.alerts.cpu == 90
assert linode.alerts.io == 10000
assert linode.alerts.network_in == 10
assert linode.alerts.network_out == 10
assert linode.alerts.transfer_quota == 80
assert isinstance(linode.alerts.system_alerts, list)
assert isinstance(linode.alerts.user_alerts, list)

linode = test_linode_client.load(Instance, parent_linode_id)
assert linode.alerts.cpu == 90
assert linode.alerts.io == 10000
assert linode.alerts.network_in == 10
assert linode.alerts.network_out == 10
assert linode.alerts.transfer_quota == 80
assert isinstance(linode.alerts.system_alerts, list)
assert isinstance(linode.alerts.user_alerts, list)

linode.alerts = {
"cpu": 50,
"io": 6000,
"network_in": 20,
"network_out": 20,
"transfer_quota": 40,
}
linode.save()

wait_for_condition(10, 100, get_status, linode, "running")
new_linode = retry_sending_request(
5,
linode.clone,
region=linode.region.id,
instance_type=linode.type.id,
label=get_test_label(),
)
assert new_linode.alerts.cpu == 90
assert new_linode.alerts.io == 10000
assert new_linode.alerts.network_in == 10
assert new_linode.alerts.network_out == 10
assert new_linode.alerts.transfer_quota == 80
assert isinstance(new_linode.alerts.system_alerts, list)
assert isinstance(new_linode.alerts.user_alerts, list)
Comment on lines +398 to +427
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In test_linode_alerts_workflow, the test updates linode.alerts (cpu/io/network_*/transfer_quota) and calls linode.save(), but none of the subsequent assertions check that the update actually took effect. As written, the test would still pass even if the save was a no-op, which weakens the intended coverage. Consider asserting the saved values after a reload, and then align the clone assertions with the intended behavior (either the clone inherits the updated alerts, or it resets to defaults—right now it asserts the same default values as before the update).

Copilot uses AI. Check for mistakes.

if new_linode is not None:
new_linode.delete()
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if new_linode is not None: is redundant here: the test already dereferences new_linode.alerts.* above, so new_linode must be non-None for the test to reach the cleanup. Prefer unconditional deletion (or a try/finally around assertions) to make the cleanup intent clearer.

Suggested change
if new_linode is not None:
new_linode.delete()
new_linode.delete()

Copilot uses AI. Check for mistakes.


def test_try_to_update_linode_alerts_legacy_and_aclp_at_the_same_time(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can consider not testing this case, because this behavior will be removed in a following api change. I will send the doc to you.

create_linode,
):
linode = create_linode

linode.alerts = {
"cpu": 50,
"io": 6000,
"network_in": 20,
"network_out": 20,
"transfer_quota": 50,
"system_alerts": [1, 436],
"user_alerts": [555],
}

with pytest.raises(ApiError) as err:
linode.save()
assert "Cannot set both legacy and ACLP alerts simultaneously" in str(
err.value
)
assert "[400] alerts" in str(err.value)


def test_linode_shutdown(create_linode):
linode = create_linode

Expand Down
Loading