Widen Avx2's associated types to 256 bits#123
Merged
valadaptive merged 2 commits intolinebender:mainfrom Nov 14, 2025
Merged
Conversation
DJMcNab
approved these changes
Nov 14, 2025
| The fallback level can be restored with the `force_support_fallback` cargo feature. We don't expect this to be necessary outside | ||
| of tests. | ||
| - Code generation for `select` and `unzip` operations on x86 has been improved. ([#115][] by [@valadaptive][]) | ||
| - Breaking change: The native-width associated types (`f32s`, `u8s`, etc.) for the `Avx2` struct have been widened from 128-bit |
Member
There was a problem hiding this comment.
In my mind, marking this as a breaking change is a decision on a knife-edge.
I probably wouldn't have myself, but I can understand why you have, and I'm perfectly happy for it to be marked as such.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 19, 2025
Stacked on #123 since it touches the same code. Adding 64-bit *integer* types is tricky because SSE4.2 and AVX2 are missing some important 64-bit operations, and I don't feel comfortable implementing those until #124 is addressed. However, we already have `mask64x[N]` and `f64x[N]` types. The `f32s` associated type has a `Bytes = <Self::u32s as Bytes>::Bytes` constraint, which misled me into thinking that a float type *needs* an associated int type, but that constraint is only there to assert that the two share the same `Bytes` type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #115 to make review of that PR easier.