[TMail] JAMES-4191: KeywordEmailQueryViewListener should clean up sharee's view upon MessageContentDeletionEvent

[quantranhong1999]

Also, RagDeletionListener was adapted.

Summary by CodeRabbit

• Bug Fixes

  • Keyword views in shared and team mailboxes now correctly reflect user access rights.
  • AI-indexed content is only removed when a message is completely unreferenced, not when other copies exist for the user.

• Tests

  • Added tests for keyword cleanup behavior across shared and team mailbox scenarios.
  • Added tests for read-rights resolution and cross-mailbox message references.

[coderabbitai]

Walkthrough

This pull request updates message deletion and keyword view handling to respect mailbox access rights. The MailboxReadRightsResolver method usersHavingReadRight is made public to support a new read-right-aware deletion flow in KeywordEmailQueryViewListener. Message content deletion events are enriched with mailbox ACL information across multiple listeners (TeamMailboxDeletedMessageVaultDeletionListener, RagDeletionListener). The RagDeletionListener now checks whether deleted message content is still referenced in other mailboxes before triggering cleanup. Test coverage is expanded to validate keyword view deletion for users losing access and message reference tracking across mailboxes.

Possibly related PRs

• ISSUE-2211 KeywordEmailQueryViewListener: should not call mailbox APIs if not concern keywords #2259: Modifies KeywordEmailQueryViewListener to respect read-rights when cleaning up keyword views on message deletion
• ISSUE-2074 User configuration for enabling RAG and drop user configur… #2077: Updates RagDeletionListener constructor signature and message content deletion handling logic
• Update James SHA1 #2014: Updates the james-project submodule commit reference, as does this PR

Suggested reviewers

• chibenwa
• Arsnael

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main change: KeywordEmailQueryViewListener cleanup of sharee's view upon MessageContentDeletionEvent, which aligns with the PR's core objective.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

tmail-backend/tmail-third-party/ai-bot/src/main/java/com/linagora/tmail/mailet/rag/RagDeletionListener.java (1)

52-52: Consider using a more descriptive system session username.

The hardcoded Username.of("admin") works because mapper operations don't require specific user privileges, but it differs from patterns elsewhere in the codebase where sessionProvider.createSystemSession(actualUsername) is used (see CleanupService, RecomputeQuotaTeamMailboxesService).

Since the session is created once at construction and reused, this is functionally correct. However, for clarity and consistency, consider using a more descriptive constant like Username.of("rag-deletion-listener") to indicate this is a technical session for internal operations.

🔧 Optional: Use descriptive system session username

-    private static final Username ADMIN = Username.of("admin");
+    private static final Username SYSTEM_USER = Username.of("rag-deletion-listener");

Also applies to: 55-72

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@tmail-backend/tmail-third-party/ai-bot/src/main/java/com/linagora/tmail/mailet/rag/RagDeletionListener.java`
at line 52, Replace the generic admin username with a descriptive system-session
name in RagDeletionListener: change the ADMIN constant (private static final
Username ADMIN = Username.of("admin")) to something like
Username.of("rag-deletion-listener") and ensure the existing use with
sessionProvider.createSystemSession(ADMIN) remains unchanged so the session is
still created once in the constructor; update any related references in this
class (constructor and methods that reuse ADMIN/session) to use the new constant
for clarity and consistency with other services like CleanupService and
RecomputeQuotaTeamMailboxesService.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@tmail-backend/tmail-third-party/ai-bot/src/main/java/com/linagora/tmail/mailet/rag/RagDeletionListener.java`:
- Line 52: Replace the generic admin username with a descriptive system-session
name in RagDeletionListener: change the ADMIN constant (private static final
Username ADMIN = Username.of("admin")) to something like
Username.of("rag-deletion-listener") and ensure the existing use with
sessionProvider.createSystemSession(ADMIN) remains unchanged so the session is
still created once in the constructor; update any related references in this
class (constructor and methods that reuse ADMIN/session) to use the new constant
for clarity and consistency with other services like CleanupService and
RecomputeQuotaTeamMailboxesService.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ce965901-c76d-427d-8589-93339d403dd4

📥 Commits

Reviewing files that changed from the base of the PR and between 954345c and c4d1858.

📒 Files selected for processing (8)

• james-project
• tmail-backend/jmap/extensions/src/main/java/com/linagora/tmail/james/jmap/event/KeywordEmailQueryViewListener.java
• tmail-backend/jmap/extensions/src/main/java/com/linagora/tmail/james/jmap/projections/MailboxReadRightsResolver.java
• tmail-backend/jmap/extensions/src/test/java/com/linagora/tmail/james/jmap/event/KeywordEmailQueryViewListenerTest.java
• tmail-backend/jmap/extensions/src/test/java/com/linagora/tmail/james/jmap/projections/MailboxReadRightsResolverTest.java
• tmail-backend/mailbox/plugin/tmail-deleted-message-vault/common/src/main/java/com/linagora/tmail/vault/TeamMailboxDeletedMessageVaultDeletionListener.java
• tmail-backend/tmail-third-party/ai-bot/src/main/java/com/linagora/tmail/mailet/rag/RagDeletionListener.java
• tmail-backend/tmail-third-party/ai-bot/src/test/java/com/linagora/tmail/mailet/rag/RagDeletionListenerTest.java

[Arsnael]

Thanks for completing this :)

[chibenwa]

Awesome tests!
Really good work.
Thanks a lot for this level of functional coverage on such a sensible fonctional topic.

[chibenwa]

Merging fast for SHA-1 upgrades