Phase 6: Configuration Cleanup#243
Draft
paultranvan wants to merge 2 commits intohardening/phase-5from
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
paultranvan
force-pushed
the
hardening/phase-6
branch
from
e2b80d0 to
9b2d681
Compare
paultranvan
force-pushed
the
hardening/phase-5
branch
from
db17b2d to
6129de9
Compare
paultranvan
force-pushed
the
hardening/phase-6
branch
from
9b2d681 to
24d7748
Compare
paultranvan
force-pushed
the
hardening/phase-5
branch
from
1ea4c31 to
5faca93
Compare
paultranvan
force-pushed
the
hardening/phase-6
branch
from
24d7748 to
39b3849
Compare
paultranvan
force-pushed
the
hardening/phase-5
branch
from
5faca93 to
805e2bc
Compare
paultranvan
force-pushed
the
hardening/phase-6
branch
from
39b3849 to
b3007f0
Compare
paultranvan
force-pushed
the
hardening/phase-5
branch
from
805e2bc to
d47a074
Compare
- Change version_base from '1.1' to None for forward compatibility - Remove TODO comment explaining the quick fix - Remove TODO comment from config.yaml _self_ line - Add 3 new tests verifying config loads correctly, values unchanged, and no version_base warnings - All 96 tests pass (93 original + 3 new)
- Add warnings import to routers/utils.py - Replace XXX comment with proper DeprecationWarning when legacy 'ragondin-' prefix is used - Warning includes clear migration instructions and example - Add 2 new tests verifying deprecation warning behavior - Test legacy prefix emits warning, current prefix does not - All 98 tests pass (93 original + 3 config + 2 deprecation)
paultranvan
force-pushed
the
hardening/phase-6
branch
from
b3007f0 to
092f15d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
version_basefor forward compatibility (suppress warnings properly)DeprecationWarningfor legacy "ragondin-" partition prefix with migration guidanceChanges
config/config.py:version_base="1.1"→version_base=None.hydra_config/config.yaml: Remove TODO commentrouters/utils.py:warnings.warn()for legacy prefix detectionconfig/test_config.py: 3 new tests (config loads, values, no warnings)routers/test_utils.py: 2 new tests (deprecation warning emitted, no warning for current prefix)Test plan
ruff check openrag/passes🤖 Generated with Claude Code