Skip to content

docs: add missing protocol to sample-conf link #10710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
suyua9 wants to merge 3 commits into from
+1 −1
Closed

docs: add missing protocol to sample-conf link #10710

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e36103
docs: add missing protocol to sample-conf link
suyua9 Apr 3, 2026
dc46fa0
docs: use repo-relative sample-conf link
suyua9 Apr 3, 2026
62a67de
docs: refine sample-conf-check wording
zuyua9 Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/MAKEFILE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ Compiles the `lnrpc` proto files.

`sample-conf-check`
-------------------
Checks whether all required options of `lnd --help` are included in [sample-lnd.conf](github.com/lightningnetwork/lnd/blob/master/sample-lnd.conf) and that the default values of `lnd --help` are also mentioned correctly.
Checks whether all required options of `lnd --help` are included in [sample-lnd.conf](https://github.com/lightningnetwork/lnd/blob/master/sample-lnd.conf) and that the default values of `lnd --help` are also mentioned correctly.
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding the protocol fixes the link, using a relative link such as [sample-lnd.conf](../sample-lnd.conf) is generally preferred for documentation within the same repository. This ensures that the link remains correct and points to the appropriate version of the file when viewing the documentation on different branches, tags, or forks. An absolute link to the master branch might lead users to a version of the configuration file that does not match their local checkout.


`scratch`
---------
Expand Down
Loading