Skip to content

config: skip creating unnecessary directories for remote DB backends #10687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThomsenDrake wants to merge 2 commits into
base: master
Choose a base branch
from
+22 −1
Open

config: skip creating unnecessary directories for remote DB backends #10687

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa3f259
config: skip creating unnecessary directories for remote DB backends
Mar 28, 2026
7ed155a
refactor: combine graph and watchtower dir creation into single if block
Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1424,15 +1424,44 @@ func ValidateConfig(cfg Config, interceptor signal.Interceptor, fileParser,
// Create the lnd directory and all other sub-directories if they don't
// already exist. This makes sure that directory trees are also created
// for files that point to outside the lnddir.
//
// We conditionally skip certain directories that are not needed when
// using a remote database backend like postgres:
// - The graph database directory (used by bbolt for channel graph)
// - The watchtower directory (used by bbolt for watchtower state)
dirs := []string{
lndDir, cfg.DataDir, cfg.networkDir,
cfg.LetsEncryptDir, towerDir, cfg.graphDatabaseDir(),
filepath.Dir(cfg.TLSCertPath), filepath.Dir(cfg.TLSKeyPath),
filepath.Dir(cfg.AdminMacPath), filepath.Dir(cfg.ReadMacPath),
filepath.Dir(cfg.InvoiceMacPath),
filepath.Dir(cfg.Tor.PrivateKeyPath),
filepath.Dir(cfg.Tor.WatchtowerKeyPath),
}

// Only create the graph database directory if we're using a local
// database backend (bbolt). Remote backends like postgres don't
// need a local directory for the graph database.
if cfg.DB.Backend != lncfg.PostgresBackend &&
cfg.DB.Backend != lncfg.EtcdBackend {

dirs = append(dirs, cfg.graphDatabaseDir())
}

// Only create the watchtower directory if we're using a local
// database backend. Remote backends store watchtower data remotely.
if cfg.DB.Backend != lncfg.PostgresBackend &&
cfg.DB.Backend != lncfg.EtcdBackend {

dirs = append(dirs, towerDir)
}
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve conciseness and avoid duplicating the backend check, you can combine the logic for adding the graph and watchtower directories into a single if block.

Suggested change
// Only create the graph database directory if we're using a local
// database backend (bbolt). Remote backends like postgres don't
// need a local directory for the graph database.
if cfg.DB.Backend != lncfg.PostgresBackend &&
cfg.DB.Backend != lncfg.EtcdBackend {
dirs = append(dirs, cfg.graphDatabaseDir())
}
// Only create the watchtower directory if we're using a local
// database backend. Remote backends store watchtower data remotely.
if cfg.DB.Backend != lncfg.PostgresBackend &&
cfg.DB.Backend != lncfg.EtcdBackend {
dirs = append(dirs, towerDir)
}
// Only create the graph and watchtower directories if we're using a
// local database backend (e.g. bbolt or sqlite). Remote backends
// like postgres or etcd don't need local directories for these.
if cfg.DB.Backend != lncfg.PostgresBackend &&
cfg.DB.Backend != lncfg.EtcdBackend {
dirs = append(dirs, cfg.graphDatabaseDir(), towerDir)
}


// Only create the Let's Encrypt directory if the feature is actually
// being used. If no domain is configured, there's no need for the
// directory.
if cfg.LetsEncryptDomain != "" {
dirs = append(dirs, cfg.LetsEncryptDir)
}

for _, dir := range dirs {
if err := makeDirectory(dir); err != nil {
return nil, err
Expand Down
Loading