Adding re-try RFQ negotiation on SCID collsion

[sergey3bv]

Should solve #1735

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the Request for Quote (RFQ) system by introducing an automatic retry mechanism for buy negotiations. Specifically, it addresses scenarios where a Short Channel ID (SCID) alias collision occurs, allowing the system to gracefully re-attempt the negotiation with a fresh RFQ ID rather than failing outright. This change improves the reliability of asset trading by making the negotiation process more resilient to transient alias conflicts.

Highlights

• SCID Alias Collision Retry: Implemented a retry mechanism for RFQ buy negotiations when a Short Channel ID (SCID) alias collision is detected, preventing critical failures and allowing the negotiation to proceed with a new RFQ ID.
• Error Handling Refinement: Introduced specific error handling for SCID alias collisions, distinguishing them as recoverable errors that trigger a retry, while other alias-related errors remain critical.
• New Helper Functions: Added isAliasCollisionErr to identify alias collision errors and retryBuyNegotiation to re-initiate the buy negotiation process.
• Comprehensive Testing: Included new unit tests to cover the alias collision detection, retry logic, and the distinction between recoverable and critical alias errors.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a retry mechanism for RFQ negotiation in the event of an SCID alias collision, which is a solid improvement for the robustness of the system. The implementation correctly identifies collision errors and triggers a new negotiation. The accompanying tests are thorough and cover the new logic well. My feedback focuses on minor code style improvements for error and log messages to better align with the repository's style guide, enhancing readability and maintainability.

[lightninglabs-deploy]

@sergey3bv, remember to re-request review from reviewers when ready