Open
Conversation
Pull Request Test Coverage Report for Build 19930111150Details
💛 - Coveralls |
guggero
force-pushed
the
itest-remote-signer
branch
2 times, most recently
from
e62df0f to
f200946
Compare
Contributor
Author
|
With |
guggero
force-pushed
the
itest-remote-signer
branch
3 times, most recently
from
f1b456f to
1e4f9ea
Compare
guggero
force-pushed
the
itest-remote-signer
branch
from
1e4f9ea to
1e2cb4a
Compare
jtobin
force-pushed
the
itest-remote-signer
branch
from
1e2cb4a to
1da61fd
Compare
Member
|
I've rebased this, as it seems easy enough to resurrect and review otherwise. Unsure we actually want to run w/remote signing mode in CI, though. |
guggero
commented
Dec 4, 2025
jtobin
force-pushed
the
itest-remote-signer
branch
from
1da61fd to
e45ed66
Compare
This commit adds a new flag to the integration test suite that starts the single lnd node (alice) either in normal or in remote-signing mode. In remote-signing mode, alice is actually a watch-only node that is connected to a seconardy signer node over RPC.
To make sure `tapd` works when the connected `lnd` node is running in remote-signing mode, we add a new CI target that runs all integration tests in that mode.
jtobin
force-pushed
the
itest-remote-signer
branch
from
e45ed66 to
0fec22a
Compare
|
@GeorgeTsagk: review reminder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on btcsuite/btcwallet#1022 and then lightningnetwork/lnd#10119 which will hopefully make it into
lnd v0.19.3-beta.Created this itest to reproduce lightninglabs/lightning-terminal#1123.
Further investigation then lead to the creation of this bug report issue: lightningnetwork/lnd#10120
So this test will not succeed until lightningnetwork/lnd#10120 is fixed. But putting up the PR as a draft as we should aim to fix that issue and then have these tests run in the CI by default.