Skip to content

Bind Channel::commitment_signed result in internal_commitment_signed

1b8617c
Select commit
Loading
Failed to load commit list.
Merged

Free holding cell in remaining quiescence-exit code paths #4415

Bind Channel::commitment_signed result in internal_commitment_signed
1b8617c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 18, 2026 in 0s

85.90% (-0.02%) compared to 0a20fa5

View this Pull Request on Codecov

85.90% (-0.02%) compared to 0a20fa5

Details

Codecov Report

❌ Patch coverage is 71.09635% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.90%. Comparing base (0a20fa5) to head (1b8617c).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channelmanager.rs 75.98% 56 Missing and 5 partials ⚠️
lightning/src/ln/channel.rs 44.68% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4415      +/-   ##
==========================================
- Coverage   85.91%   85.90%   -0.02%     
==========================================
  Files         156      156              
  Lines      103963   103990      +27     
  Branches   103963   103990      +27     
==========================================
+ Hits        89322    89333      +11     
- Misses      12119    12135      +16     
  Partials     2522     2522              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.