Skip to content

lightning-block-sync: switch to bitreq, drop chunked_transfer #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 2 commits into from
Feb 19, 2026

Error api change- replaced io::error with string based format

16ea4c7
Select commit
Loading
Failed to load commit list.
Merged

lightning-block-sync: switch to bitreq, drop chunked_transfer #4350

Error api change- replaced io::error with string based format
16ea4c7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 19, 2026 in 1s

85.86% (-0.05%) compared to 153e57e

View this Pull Request on Codecov

85.86% (-0.05%) compared to 153e57e

Details

Codecov Report

❌ Patch coverage is 70.73171% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.86%. Comparing base (153e57e) to head (16ea4c7).

Files with missing lines Patch % Lines
lightning-block-sync/src/convert.rs 53.33% 39 Missing and 3 partials ⚠️
lightning-block-sync/src/http.rs 83.72% 16 Missing and 5 partials ⚠️
lightning-block-sync/src/rpc.rs 65.38% 13 Missing and 5 partials ⚠️
lightning-block-sync/src/rest.rs 81.25% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4350      +/-   ##
==========================================
- Coverage   85.90%   85.86%   -0.05%     
==========================================
  Files         156      156              
  Lines      103965   103731     -234     
  Branches   103965   103731     -234     
==========================================
- Hits        89316    89071     -245     
- Misses      12128    12160      +32     
+ Partials     2521     2500      -21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov