Skip to content

Split splice initiation into two phases #4290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 7 commits into from
Feb 17, 2026

Consistently log in propose_quiescence

20916b7
Select commit
Loading
Failed to load commit list.
Merged

Split splice initiation into two phases #4290

Consistently log in propose_quiescence
20916b7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 17, 2026 in 0s

85.89% (-0.20%) compared to 3497b59

View this Pull Request on Codecov

85.89% (-0.20%) compared to 3497b59

Details

Codecov Report

❌ Patch coverage is 73.59477% with 202 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.89%. Comparing base (3497b59) to head (20916b7).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 56.18% 83 Missing and 2 partials ⚠️
lightning/src/ln/funding.rs 82.50% 47 Missing and 20 partials ⚠️
lightning/src/ln/channelmanager.rs 52.00% 36 Missing ⚠️
lightning/src/events/bump_transaction/mod.rs 85.50% 6 Missing and 4 partials ⚠️
lightning/src/ln/functional_test_utils.rs 50.00% 3 Missing ⚠️
lightning/src/util/ser.rs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4290      +/-   ##
==========================================
- Coverage   86.09%   85.89%   -0.20%     
==========================================
  Files         156      156              
  Lines      103623   103963     +340     
  Branches   103623   103963     +340     
==========================================
+ Hits        89211    89304      +93     
- Misses      11895    12132     +237     
- Partials     2517     2527      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov