Skip to content

Rework ChannelManager::funding_transaction_signed #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 2 commits into from
Jan 20, 2026

Delay processing splice initial commitment signed from counterparty

e502ce3
Select commit
Loading
Failed to load commit list.
Merged

Rework ChannelManager::funding_transaction_signed #4257

Delay processing splice initial commitment signed from counterparty
e502ce3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 15, 2026 in 1s

86.60% (+0.01%) compared to c5d7b13

View this Pull Request on Codecov

86.60% (+0.01%) compared to c5d7b13

Details

Codecov Report

❌ Patch coverage is 74.49664% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.60%. Comparing base (c5d7b13) to head (e502ce3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 81.32% 23 Missing and 8 partials ⚠️
lightning/src/ln/splicing_tests.rs 0.00% 23 Missing ⚠️
lightning/src/ln/channelmanager.rs 78.02% 18 Missing and 2 partials ⚠️
lightning/src/events/mod.rs 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4257      +/-   ##
==========================================
+ Coverage   86.59%   86.60%   +0.01%     
==========================================
  Files         158      158              
  Lines      102368   102376       +8     
  Branches   102368   102376       +8     
==========================================
+ Hits        88641    88659      +18     
+ Misses      11313    11297      -16     
- Partials     2414     2420       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov