fix for code warnings at compiation time

[vyast-softserveinc]

No description provided.

[pavlo-hilei]

This fixes warnings, but does it fix an underlying issue? Please check comments

[pavlo-hilei]

Is that a correct behavior that LessEqual translates to LessThan?

[pavlo-hilei]

Is that okay that we skip other BinOp cases?

[vyast-softserveinc]

This is how it was. I would imagine that there could be any kind of Binary/Unary operation for example:

struct MyInfo { int sizes[3] };
....
@kernel void func(..., MyInfo* ptr) {
    @outer for(int i =0 ; i <  *ptr.sizes[0]; i += *ptr.sizes[2]) {
       ...
     }
}

As far as I can see we just pass it as is

[kchabSS]

Is that a correct behavior that LessEqual translates to LessThan?
Yes. That's correct.

[pavlo-hilei]

But we still don't handle UnOp::Other case, which will leave firstMeta.inc.op.bo uninitialized

[vyast-softserveinc]

I would ask the author of this code what should happen

[kchabSS]

the ::Other were originally there as default values.
In case OP cannot be properly detected (or there is no increment/decrement at all), the default Other is set.
If the Other is detected at the end of loop parsing, an error must be raised.
That is how it was originally written for launcher PoC.

[vyast-softserveinc]

Ok in general I can rename other as unsupported and then provide an error. Have to add the tests and check under the original occa.

[kchabSS]

The changes look OK.

[kchabSS]

Is that a correct behavior that LessEqual translates to LessThan?
Yes. That's correct.