This repository was archived by the owner on Nov 21, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
[WIP] Use config module #42
Open
davidcmoulton
wants to merge
43
commits into
libero:master
Choose a base branch
from
davidcmoulton:use-config-module
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
377afbb
Add config manager module as a dependency
davidcmoulton 10607d1
Update Gulp file to use @libero/pattern-library-config-manager from npm
davidcmoulton 72ec0a0
Update config manager dependency
davidcmoulton dbe12c1
Update config manager dependency
davidcmoulton b784334
Update config manager dependency
davidcmoulton cbe75ad
Delete obsolete built-in config generation
davidcmoulton a5e2768
Remove references to obsolete built-in config generation
davidcmoulton b2e4a32
Add font-size mixin with tests
davidcmoulton 64285cf
Update config manager to latest version for it sass string export change
davidcmoulton ee4be32
Add font-family mixin with tests
davidcmoulton abe72e0
Introduce get-font-size sass function
davidcmoulton dcd8988
Improve test fixture
davidcmoulton 166c0ef
Reset reference to a subject under test (sass)
davidcmoulton e83c283
Update .gitignore to ignore .sass-cache/ everywhere
davidcmoulton e9a7fa5
Improve font-family mixin
davidcmoulton ff959a0
Tweak style lint rules
davidcmoulton 632e74a
Use css custom properties in font-family mixin
davidcmoulton 79bd471
Improve font-size mixin, allow rem-based numbers
davidcmoulton 5d64246
Add set-color mixin
davidcmoulton 95fb46c
Add set-background-color mixin
davidcmoulton 28edc84
Improve internals of color handling
davidcmoulton 1aff125
Bug fix in @font-family mixin
davidcmoulton bdc6881
Improve test wording
davidcmoulton 9f2cb7f
Parameter order
davidcmoulton c42e421
Rework label-content-typography mixin with tests
davidcmoulton 12bcaf4
Minor improvements and tests
davidcmoulton 41e393a
Improve test wording
davidcmoulton 293fd04
Nesting
davidcmoulton f951419
Consolidate heading typography mixins; use heading css custom properties
davidcmoulton 3c6520d
Streamline sass heading mixin a bit
davidcmoulton 72a8051
Update normalise to use function to get a map-defined color
davidcmoulton 53081db
Add function to get baseline grid measures from map
davidcmoulton e0bd4f3
Remove obsolete comment
davidcmoulton 30ab5ce
Add function to get breakpoint from the breakpoint map
davidcmoulton 0e2e017
Use updated config names
davidcmoulton 05cf864
Add tests for set-font-size-and-vertical-height
davidcmoulton fde5765
Merge branch 'master' into use-config-module
davidcmoulton d270ac8
Simplify, and add tests for, blg-spacing mixin
davidcmoulton fc5efca
Add accessor for grid map
davidcmoulton 589200f
Remove parentheses from spacing mixin signatures that don't take params
davidcmoulton 1e6ffa8
Merge branch 'master' into use-config-module
davidcmoulton 4e6e3e7
Merge remote-tracking branch 'libero/master' into use-config-module
davidcmoulton a9a6b96
Fix sass import loop
davidcmoulton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| /.sass-cache/ | ||
| /**/*.sass-cache/ | ||
| /export/ | ||
| /node_modules/ | ||
| /pattern-library-*.tar.gz | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the actual config should remain here...