This repository was archived by the owner on Nov 21, 2019. It is now read-only.
Separate View into different implementations#63
Merged
thewilkybarkid merged 13 commits intolibero:masterfrom Apr 4, 2019
Merged
Separate View into different implementations#63thewilkybarkid merged 13 commits intolibero:masterfrom
thewilkybarkid merged 13 commits intolibero:masterfrom
Conversation
Contributor
Author
|
As pointed out by @nlisgo, doesn't actually rely on libero/pattern-library#76 so we can separate them. |
…ew implement ArrayAccess
Contributor
Author
|
Bit of refactoring done with #64 in mind. |
Contributor
|
Happy with these changes. It is a useful distinction. |
Contributor
Author
|
Any more comments @giorgiosironi? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#56 gave rise to the idea of having a lazy
View. That experiment hacked it in; but it's better to have a real proxy implementation. After a bit of thought, we already have the need for different implementations (primarily to stop simple strings having to be rendered as a template). So, after a bit of a refactor in libero/pattern-library#76 we can have a separateStringViewto handle that case.