NumericVector::is_effectively_serial(), to avoid overloading metadata#4428
Merged
roystgnr merged 3 commits intolibMesh:develfrom Mar 27, 2026
Merged
NumericVector::is_effectively_serial(), to avoid overloading metadata#4428roystgnr merged 3 commits intolibMesh:develfrom
roystgnr merged 3 commits intolibMesh:develfrom
Conversation
Shorthand to make it easier to determine whether a vector can be handled using optimized-for-serial code paths regardless of its conceptual status.
This ought to preserve the performance improvements of Seq vectors and serial codepaths without losing PARALLEL-vs-GHOSTED metadata.
Member
|
Thanks, this fixes the original test that was failing for me, I'm going to temporarily push your branch into upstream so that I can run all of our internal testing on it as well. |
Member
|
Huh, looks like maybe only one MOOSE test doesn't like this. |
Member
Author
|
It's so insulting when just one test fails. "Hey, your code sucks and your test coverage sucks!" I can reproduce this but probably won't find time to fix it before tomorrow. |
And even in the serial case our metadata should reflect that. This fixes a conflict with MOOSE restarts (which want to save a subvector in one cases but can't save a ghosted vector) for me.
jwpeterson
approved these changes
Mar 26, 2026
Member
Author
|
@lindsayad won't have time to check this for performance regressions for a while, but it's at least fixing correctness regressions so he's good with us merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully this will fix the regressions @jwpeterson saw in write-1-to-read-N after #4374