Skip to content

fix(issue#4316): color calc inside from expression #4434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
puckowski wants to merge 2 commits into
base: master
Choose a base branch
from
+16 −2
Open

fix(issue#4316): color calc inside from expression #4434

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08733a7
fix(issue#4316): color calc inside from expression
puckowski Mar 22, 2026
f69f821
Merge branch 'master' into master_fix_4316
matthew-dean Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/less/lib/less/parser/parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2283,10 +2283,10 @@ const Parser = function Parser(context, imports, fileInfo, currentIndex) {
parserInput.save();

// hsl or rgb or lch operand
const match = parserInput.$re(/^[lchrgbs]\s+/);
const match = parserInput.$re(/^([lchrgbs])(?=\s|[,/*)]|$)/);
if (match) {
parserInput.forget();
return new tree.Keyword(match[0]);
return new tree.Keyword(match[1]);
}

parserInput.restore();
Expand Down
6 changes: 6 additions & 0 deletions packages/test-data/tests-unit/color-functions/modern.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,9 @@
.color-rgb-div {
background: rgb(from #0000FF calc(r / 2) g b);
}
.color-rgb-sub-right-operand {
background: rgb(from blue calc(100 - r) g b);
}
.color-rgb-add-left-operand {
background: rgb(from blue calc(r + 100) g b);
}
8 changes: 8 additions & 0 deletions packages/test-data/tests-unit/color-functions/modern.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,11 @@
.color-rgb-div {
background: rgb(from #0000FF calc(r / 2) g b);
}

.color-rgb-sub-right-operand {
background: rgb(from blue calc(100 - r) g b);
}

.color-rgb-add-left-operand {
background: rgb(from blue calc(r + 100) g b);
}
Loading