occur: Allow ledger-occur to specify multiple combined filters#466
Open
bcc32 wants to merge 2 commits intoledger:masterfrom
Open
occur: Allow ledger-occur to specify multiple combined filters#466bcc32 wants to merge 2 commits intoledger:masterfrom
bcc32 wants to merge 2 commits intoledger:masterfrom
Conversation
Also remove some slightly overly-verbose comments.
- C-c C-f when narrowing is already in effect no longer immediately clears it - C-c C-f may be used to specify additional filters which are ANDed with previous ones - C-u C-c C-f may be used to pop the most recently-specified filter - C-u C-u C-c C-f may be used to remove all filters without prompting - ledger-occur-mode no longer automatically disables itself when there are no matches, as the user may simply wish to remove a single filter from the list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes ledger-occur to allow the user to specify multiple combined
filters. Unlike combining multiple search terms in the same regexp, this
functionality is easier to use and is insensitive to the order that search terms
occur in a transaction.
This makes some slightly incompatible changes to the command's UI, but I think
the improvement is worth it.
previous ones
matches, as the user may simply wish to remove a single filter from the list