Open
Conversation
Also, fix how we're resetting settings, so that if the user is running ERT tests interactively, their customizations don't affect the test results. This ensures that tests have a consistent environment before and after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consists of a few commits cleaning up some issues with running the
ledger ERT tests interactively. Some of them are still a little unreliable, but
this PR makes the following improvements:
ledger-tests-with-temp-filewill now reset ledger customizations to theactual defaults and not the user's customized value. (This will also affect
the user's session, if they're running the ledger tests in their regular
Emacs, but that is hard to avoid.)
ledger-tests-with-temp-filebeginning to run.