Hold on to ledger-reports variable's local value#440
Open
errge wants to merge 1 commit intoledger:masterfrom
Open
Hold on to ledger-reports variable's local value#440errge wants to merge 1 commit intoledger:masterfrom
errge wants to merge 1 commit intoledger:masterfrom
Conversation
When ledger-reports is defined as a file local variable, we have to inherit that local setting to the report buffer.
bcc32
requested changes
Mar 13, 2025
Collaborator
bcc32
left a comment
bcc32
left a comment
There was a problem hiding this comment.
Sorry for the long delay, I haven't had time to look at this project in a few months but am hoping to spend some time helping get it into shape for a new release.
Do you mind adding a regression test for this issue?
| (let* ((file (ledger-master-file)) | ||
| (buf (find-file-noselect file))) | ||
| (buf (find-file-noselect file)) | ||
| (local-ledger-reports (when (local-variable-p 'ledger-reports) ledger-reports))) |
Collaborator
There was a problem hiding this comment.
I think it would be simpler to unconditionally use whatever value ledger-reports has in the current buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ledger-reports is defined as a file local variable, we have to inherit that local setting to the report buffer.