ledger-complete: Read flycheck-ledger-pedantic in addition to ledger-flymake-be-pedantic#378
Open
bcc32 wants to merge 2 commits intoledger:masterfrom
Open
ledger-complete: Read flycheck-ledger-pedantic in addition to ledger-flymake-be-pedantic#378bcc32 wants to merge 2 commits intoledger:masterfrom
bcc32 wants to merge 2 commits intoledger:masterfrom
Conversation
Member
|
Hmm, it remains extremely hacky to be modifying the results returned by this function based on globals. |
bcc32
force-pushed
the
flycheck-pedantic
branch
from
09df5ef to
f626098
Compare
Collaborator
Author
|
I pushed a new commit that proposes the following change: The following functions now take an optional argument
And now, However, this change is potentially breaking since the optional argument's default may not coincide with the corresponding setting of |
bcc32
force-pushed
the
flycheck-pedantic
branch
from
f626098 to
7b9a668
Compare
bcc32
force-pushed
the
flycheck-pedantic
branch
from
7b9a668 to
78e7394
Compare
…flymake-be-pedantic
The fact that ledger-accounts-in-buffer, even when called from Lisp, depends on a user customization related to flymake, is kind of an ugly hack. Here, we move it to the completion function instead, which at least has a better excuse for its behavior to depend on customizations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.