Add option to shuffle test files.#21
Open
floere wants to merge 3 commits intoleahneukirchen:masterfrom
Open
Conversation
This adds a -u/--shuffle option (default is "do not shuffle", as it is currently).
Contributor
|
👍 This is something that comes up most often across platforms where the default FS order might be different, e.g. local OS X remote (TravisCI) Linux. One thing I’d like to see added is printing the full command that you can copy-paste to easily reproduce the results locally. |
Author
|
I completely forgot to add that at least in case of shuffling, the file order used should be printed (thanks @alloy for the reminder). But perhaps let's discuss this PR first. |
Contributor
|
I think it’s an essential part of this UX feature and important to take into consideration when thinking about the usefulness of it. |
…fle SEED to use specific SEED).
Author
|
Travis is failing because this is 1.9.3+ code only. |
|
Is there a chance this can get merged in or does Bacon support Ruby 1.8? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an idea that I'd like to put forth:
Add "shuffle" option. This adds a -u/--shuffle option (default is "do not shuffle", as it is currently).
Reason:
I really do like the new -a option. However, I do believe - ymmv - that tests should be run in random order to detect setup/code loading issues.
Currently, I do have to use something akin to
FileList["spec/#{dir}/*_spec.rb"].shuffle.join ' 'to make this happen, which negates the benefits of-a.Always shuffling, adding a shuffle option (e.g.
-u), or always shuffling on -a would be my wish-order.I'd like to put this idea up for discussion. Thanks for considering it :)