Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
@MegaIng I basically used your code, with very little changes. I didn't encounter any complications, so maybe I missed it. |
MegaIng
suggested changes
Sep 7, 2024
Member
MegaIng
left a comment
MegaIng
left a comment
There was a problem hiding this comment.
Looks good! No comments on the implementation itself. (It is after all a version of my implementation :-)) However, I think a bit of documentation would be nice:
- Make sure
TextSliceappears in the doc pages - Add a docstring for it
- Mention the ability to deal with
TextSlicein the parsing methods, and especially mention thatlexer='dynamic'can't (yet) deal with it.
Based on previous PR by MegaIng
Member
Author
|
Added. Let me know if I forgot to mention something. |
Member
Author
|
If no one objects, I will merge this soon. @MegaIng |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on previous PR by MegaIng. See #1429