fix: add default value to grep tool glob schema for strict mode compatibility#422
Merged
Christian Bromann (christian-bromann) merged 3 commits intolangchain-ai:mainfrom Apr 4, 2026
Conversation
…tibility The grep tool's `glob` field was defined with `.optional().nullable()` but without `.default()`, causing it to be excluded from the JSON schema `required` array. This violates OpenAI's strict mode requirement that all properties must be listed in `required`. Fixes langchain-ai#401
🦋 Changeset detectedLatest commit: 1961aa2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Christian Bromann (christian-bromann)
approved these changes
Apr 3, 2026
Added a default value to the grep tool glob schema to ensure compatibility with strict mode.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
globfield was defined with.optional().nullable()but without.default(),causing it to be excluded from the JSON schema
requiredarray.required,resulting in a 400 error when using
providerStrategywith OpenAI models..default(null)to theglobfield and a test verifying all tool schema propertiesare included in
required.Fixes #401
Test plan
requiredarrayglobincluded inrequired).default(null)) would fail the new test