fix: add --load to buildx to ensure images are available locally#133
Open
AaronFeledy wants to merge 1 commit intomainfrom
Open
fix: add --load to buildx to ensure images are available locally#133AaronFeledy wants to merge 1 commit intomainfrom
AaronFeledy wants to merge 1 commit intomainfrom
Conversation
When building v4 services with buildx, the resulting image may not be found by Docker Compose because buildx only stores images in its cache by default. Adding --load exports the build result into the local Docker daemon. Backport of lando/core#424
✅ Deploy Preview for lando-core-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of lando/core#424.
When building v4 services with buildx, the resulting image may not be found by Docker Compose:
By default,
docker buildx buildonly stores images in the buildx cache, not the local Docker daemon's image store. Adding--load(--output=type=docker) exports the build result into the local daemon.Change
One line added to
components/docker-engine.js—'--load'in the buildx args array.Note
Low Risk
Single-flag change to the buildx command plus changelog entry; low risk aside from possible performance/behavior differences when loading images into the local daemon.
Overview
Ensures
buildx-built images are available in the local Docker daemon by adding--loadto thedocker buildx buildinvocation incomponents/docker-engine.js, preventing "no such image" failures when later referenced (e.g., by Compose).Updates
CHANGELOG.mdto document the fix and reference the upstream backport.Written by Cursor Bugbot for commit fc4fd8e. This will update automatically on new commits. Configure here.