Skip to content

Avoid importing alloc::sync on platforms that do not have it #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AverageHelper wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Avoid importing alloc::sync on platforms that do not have it #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ec6405
fix: don't import alloc::sync on platforms without it
AverageHelper Mar 23, 2026
6af4988
chore: update changelog
AverageHelper Mar 23, 2026
3dfa383
fix(changelog): whoops! i guessed the PR number wrong 😅
AverageHelper Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

- Update to Rust 2024
[#487](https://github.com/lambda-fairy/maud/pull/487)
- Support platforms witout `alloc::sync` support.
[#492](https://github.com/lambda-fairy/maud/pull/492)

## [0.27.0] - 2025-02-02

Expand Down
5 changes: 3 additions & 2 deletions maud/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

extern crate alloc;

use alloc::{borrow::Cow, boxed::Box, string::String, sync::Arc};
use alloc::{borrow::Cow, boxed::Box, string::String};
use core::fmt::{self, Arguments, Display, Write};

pub use maud_macros::html;
Expand Down Expand Up @@ -150,7 +150,8 @@ impl<T: Render + ?Sized> Render for Box<T> {
}
}

impl<T: Render + ?Sized> Render for Arc<T> {
#[cfg(target_has_atomic = "ptr")]
impl<T: Render + ?Sized> Render for alloc::sync::Arc<T> {
fn render_to(&self, w: &mut String) {
T::render_to(self, w);
}
Expand Down
Loading