Added rudimentary hexagonal renderer#76
Open
AndreRenaud wants to merge 3 commits intolafriks:mainfrom
Open
Conversation
Owner
|
Can you add some small sample map to test this with? |
Author
|
I've pushed a map, which made me realise that I'd only done the Y orientation. There are some caveats here, and this is very simplistic, but hopefully sufficient to start with. |
Author
|
Hey - just pinging this PR to see if theres anything more you'd like me to do to hopefully get it merged? |
Owner
|
I had not yet time to test it, will do it soon |
activey
reviewed
Sep 12, 2024
|
|
||
| var xs, xe, xi, ys, ye, yi int | ||
| if r.m.RenderOrder == "" || r.m.RenderOrder == "right-down" { | ||
| var odd bool |
There was a problem hiding this comment.
Maybe you can introduce some strategy pattern here already? these if's will become hard to maintain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very simplistic, and due to the limited rendering order options at the moment it has some visual artifacts. However it does render things in a reasonable manner to the screen.