Reduce API surface in bundledescription package#164
Draft
Conversation
- Changed addImportPackages from public to private (only used internally) - Changed checkImportExportSyntax from public to private (only used internally) - Fixed StateMsg to reference correct bundle name path for StateMessages.properties Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Changed multiple package-level static helper methods to private since they are only used within BundleDescriptionBuilder: - createRequiredBundle - createExportPackages - addExportPackages - getDirectives - getAttributes - createHostSpecification - convertBREEs - getOSGiEENameVersion - createOSGiRequires - createOSGiCapabilities (both overloads) Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Changed package-level constants to private since they are only used within BundleDescriptionBuilder: - DEFINED_BSN_DIRECTIVES - DEFINED_BSN_MATCHING_ATTRS - GENERIC_REQUIRE - GENERIC_CAPABILITY Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Analyze and remove unnecessary code in BundleDescriptionBuilder
Reduce API surface in bundledescription package
Oct 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BundleDescriptionBuilder was migrated from a larger codebase with methods and constants left unnecessarily exposed. Only
createBundleDescription()is called externally by BundlesAction.Changes
Visibility reductions
addImportPackages,checkImportExportSyntaxcreateRequiredBundle,createExportPackages,addExportPackages,getDirectives,getAttributes,createHostSpecification,convertBREEs,getOSGiEENameVersion,createOSGiRequires,createOSGiCapabilities(2 overloads)DEFINED_BSN_DIRECTIVES,DEFINED_BSN_MATCHING_ATTRS,GENERIC_REQUIRE,GENERIC_CAPABILITYBug fix
org.eclipse.osgi.internal.resolver.StateMessagestoorg.eclipse.equinox.internal.p2.publisher.eclipse.bundledescription.StateMessagesThe package remains internal (not exported). Constants used by other classes in the package (NAME, FRIENDS_DIRECTIVE, INTERNAL_DIRECTIVE, etc.) remain package-visible.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.