fix(BA-4096): avoid nested bind mount of DO_NOT_STORE_PERSISTENT_FILES_HERE.md#10944
Open
seedspirit wants to merge 5 commits intomainfrom
Open
fix(BA-4096): avoid nested bind mount of DO_NOT_STORE_PERSISTENT_FILES_HERE.md#10944seedspirit wants to merge 5 commits intomainfrom
seedspirit wants to merge 5 commits intomainfrom
Conversation
…ES_HERE.md Dropping the bind mount in mount_krunner() is the first step of fixing session creation on macOS with Docker Desktop VirtioFS, where runc rejects the nested mountpoint as "outside of rootfs". The file will instead be copied during scratch provisioning in a follow-up commit.
…om KernelRunnerMountProvisioner Remove the nested bind mount entry for DO_NOT_STORE_PERSISTENT_FILES_HERE.md from the new KernelRunnerMountProvisioner path so the fix is preserved when this code path is wired up. The file will be copied into the scratch work directory during provisioning instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… work_dir Instead of bind-mounting the warning doc into /home/work (which fails on macOS Docker Desktop VirtioFS due to nested bind mount resolution), copy it into the scratch work directory during provisioning, matching how .bashrc, .vimrc, and other dotfiles are handled.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Stops a nested bind mount of DO_NOT_STORE_PERSISTENT_FILES_HERE.md (problematic on macOS Docker Desktop VirtioFS) by provisioning the file into the scratch work/ directory instead of bind-mounting it.
Changes:
- Copy
DO_NOT_STORE_PERSISTENT_FILES_HERE.mdinto the scratchwork/directory during scratch provisioning and ensure ownership is applied. - Remove the nested bind mount for the markdown file from both the kernel runner mounts and the legacy
agent.pymount path. - Add a changelog entry documenting the fix.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ai/backend/agent/stage/kernel_lifecycle/docker/scratch.py | Copies the warning markdown into scratch work/ and includes it in chown paths. |
| src/ai/backend/agent/stage/kernel_lifecycle/docker/mount/krunner.py | Removes the bind mount that previously mounted the markdown into /home/work. |
| src/ai/backend/agent/agent.py | Removes the legacy bind mount of the markdown file into /home/work. |
| changes/10944.fix.md | Documents the macOS VirtioFS nested bind mount fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DO_NOT_STORE_PERSISTENT_FILES_HERE.mdat/home/work/DO_NOT_STORE_PERSISTENT_FILES_HERE.md; this was a nested bind mount (on top of the/home/workbind mount) that runc rejects on macOS Docker Desktop with VirtioFS because virtiofs resolves the nested path to/run/host_virtiofs/..., outside the container rootfs.work/directory during scratch provisioning instead, matching how dotfiles (.bashrc,.vimrc, etc.) and the Kubernetes agent path already handle it.agent.py:mount_krunner) and the not-yet-wiredKernelRunnerMountProvisionerso the fix isn't lost when the new path is activated.Test plan
cat /home/work/DO_NOT_STORE_PERSISTENT_FILES_HERE.mdshows the original content/home/work/DO_NOT_STORE_PERSISTENT_FILES_HERE.mdResolves BA-4096