feat(BA-5577): handle operation client recovery when monitor client is healthy#10807
Draft
jopemachine wants to merge 2 commits intomainfrom
Draft
feat(BA-5577): handle operation client recovery when monitor client is healthy#10807jopemachine wants to merge 2 commits intomainfrom
jopemachine wants to merge 2 commits intomainfrom
Conversation
jopemachine
added a commit
that referenced
this pull request
Apr 6, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
334323b to
c7ad9d0
Compare
adb02bb to
1193c22
Compare
Base automatically changed from
feat/BA-5578-valkey-client-acquire-pattern
to
main
April 7, 2026 05:36
… sub-components When the operation client is broken but the monitor client is healthy, reconnect only the operation client instead of tearing down both. Expose operation/monitor sub-component health status through the internal health API so external monitoring can distinguish their states. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1193c22 to
20388fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/healthendpoint) so external monitoring can distinguish their statesValkeyOperationPingableprotocol for health checkers to detectMonitoringValkeyClientand report per-sub-component healthChanges
MonitoringValkeyClient: Add_reconnect_operation_only(),_is_monitor_healthy(),ping_operation_client()methods; modify monitor loop for selective reconnectionComponentHealthStatus/ComponentConnectivityStatus: Add optionalsub_componentsfieldValkeyHealthChecker: DetectValkeyOperationPingableclients and report operation/monitor sub-component health separatelyHealthProbe: Pass through sub-component data to DTOsTest plan
test_selective_reconnection_operation_only_when_monitor_healthy— operation-only reconnect when monitor is healthytest_full_reconnect_when_both_unhealthy— full reconnect when both are brokentest_monitor_loop_selective_reconnect_integration— end-to-end with monitor looptest_ping_operation_client— direct operation client pingtest_reports_sub_components_for_monitoring_client— health checker sub-component reportingtest_no_sub_components_for_basic_client— basic clients have no sub-componentstest_detects_operation_client_failure— health checker detects operation-only failure🤖 Generated with Claude Code