Skip to content

Updated KEP-3314 with install instructions for the SnapshotMetadataService CRD#5935

Open
carlbraganza wants to merge 1 commit intokubernetes:masterfrom
carlbraganza:kep-3314-crd-install
Open

Updated KEP-3314 with install instructions for the SnapshotMetadataService CRD#5935
carlbraganza wants to merge 1 commit intokubernetes:masterfrom
carlbraganza:kep-3314-crd-install

Conversation

@carlbraganza
Copy link
Contributor

@carlbraganza carlbraganza commented Feb 24, 2026

  • One-line PR description: Added instructions for the installation of the SnapshotMetadataService CRD to KEP-3314
  • Other comments:

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 24, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carlbraganza
Once this PR has been reviewed and has the lgtm label, please assign saad-ali for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Feb 24, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 24, 2026

Hi @carlbraganza. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Feb 24, 2026
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 24, 2026
xing-yang
xing-yang reviewed Feb 25, 2026
View reviewed changes
xing-yang
xing-yang reviewed Feb 25, 2026
View reviewed changes
keps/sig-storage/3314-csi-changed-block-tracking/README.md
The value should be unique to the service if possible; for example, it could be the DNS name of the service.

The full Custom Resource Definition is shown below:
The `SnapshotMetadataService` Custom Resource Definition should be installed by the cluster administrator.
Copy link
Contributor

@xing-yang xing-yang Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes distro

Copy link
Contributor

@bswartz bswartz Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention both. Ultimately it's a cluster admin responsibility, but the distro should help with the installation as much as possible. In the short term we need a fallback way for the admin to do it on distros that lack support for the feature. In the long term, that fallback should become unnecessary

Copy link
Contributor Author

@carlbraganza carlbraganza Mar 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewording to say:

The [SnapshotMetadataService CRD](https://github.com/kubernetes-csi/external-snapshot-metadata/blob/3a139dd44d4ffa01343a91bed40996b1db56fd38/client/config/crd/cbt.storage.k8s.io_snapshotmetadataservices.yaml)
should be installed either by the Kubernetes distribution or the cluster administrator.

Copy link
Contributor

@bswartz bswartz Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this rewording yet, please push a commit

@xing-yang
Copy link
Contributor

xing-yang commented Feb 25, 2026

/assign @bswartz

@xing-yang
Copy link
Contributor

xing-yang commented Mar 4, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2026
@carlbraganza carlbraganza force-pushed the kep-3314-crd-install branch from 56af492 to 8779785 Compare March 4, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xing-yang xing-yang xing-yang left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

+1 more reviewer

@bswartz bswartz bswartz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bswartz bswartz

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carlbraganza @k8s-ci-robot @xing-yang @bswartz