Skip to content

removed HonorPVReclaimPolicy feature flag from csi-azuredisk addon#4064

Open
bastianpaetzold wants to merge 1 commit intokubermatic:mainfrom
bastianpaetzold:feature/fix-csi-azuredisk-controller-not-starting
Open

removed HonorPVReclaimPolicy feature flag from csi-azuredisk addon#4064
bastianpaetzold wants to merge 1 commit intokubermatic:mainfrom
bastianpaetzold:feature/fix-csi-azuredisk-controller-not-starting

Conversation

@bastianpaetzold
Copy link
Copy Markdown

What this PR does / why we need it:
Remove the HonorPVReclaimPolicy feature flag from csi-azuredisk addon, since it reached GA in the latest external-provisioner version (see https://github.com/kubernetes-csi/external-provisioner/releases/tag/v6.2.0), which is included in version 1.34.3 of the azuredisk-csi-driver (see https://github.com/kubernetes-sigs/azuredisk-csi-driver/releases/tag/v1.34.3).

This fixes an startup issue of the csi-azuredisk-controller deployments, because the csi-provisioner container doesn't seem to recognise the HonorPVReclaimPolicy feature flag in the latest version anymore and therefore fails.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind bug

Special notes for your reviewer:
The PR for 6.2.0 in the external-provisioner repo includes the same change for their deployment files: https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/3534/changes#diff-75dad117d4fe938361cf652504389cb8709dfbd41ac9ad51c1756bcd1a6d8ebb

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix csi-azuredisk-controller pods crashing on startup.

Documentation:

NONE

Signed-off-by: Bastian Pätzold <37421217+bastianpaetzold@users.noreply.github.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. labels Apr 30, 2026
@kubermatic-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign soer3n for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 30, 2026
@kubermatic-bot
Copy link
Copy Markdown
Contributor

Hi @bastianpaetzold. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants