removed HonorPVReclaimPolicy feature flag from csi-azuredisk addon#4064
Conversation
Signed-off-by: Bastian Pätzold <37421217+bastianpaetzold@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @bastianpaetzold. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Remove the HonorPVReclaimPolicy feature flag from csi-azuredisk addon, since it reached GA in the latest external-provisioner version (see https://github.com/kubernetes-csi/external-provisioner/releases/tag/v6.2.0), which is included in version 1.34.3 of the azuredisk-csi-driver (see https://github.com/kubernetes-sigs/azuredisk-csi-driver/releases/tag/v1.34.3).
This fixes an startup issue of the csi-azuredisk-controller deployments, because the csi-provisioner container doesn't seem to recognise the HonorPVReclaimPolicy feature flag in the latest version anymore and therefore fails.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind bug
Special notes for your reviewer:
The PR for 6.2.0 in the external-provisioner repo includes the same change for their deployment files: https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/3534/changes#diff-75dad117d4fe938361cf652504389cb8709dfbd41ac9ad51c1756bcd1a6d8ebb
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: