feat: Stabilize ResourceGroup API to v1 with backward compatibility#4467
feat: Stabilize ResourceGroup API to v1 with backward compatibility#4467NETIZEN-11 wants to merge 7 commits intokptdev:mainfrom
Conversation
…nctions - Upgrade sigs.k8s.io/kustomize/api from v0.20.1 to v0.21.0 - Upgrade sigs.k8s.io/kustomize/kyaml from v0.20.1 to v0.21.0 - Upgrade k8s.io/api from v0.34.1 to v0.35.0 - Upgrade k8s.io/apimachinery from v0.34.1 to v0.35.0 - Upgrade k8s.io/kubectl from v0.34.1 to v0.35.0 - Upgrade github.com/kptdev/krm-functions-catalog/functions/go/apply-setters from v0.2.2 to v0.2.4 - Update catalog function registry to reference new apply-setters version - Run go mod tidy to resolve transitive dependencies Resolves GitHub Issue kptdev#4406 All catalog functions remain compatible with new APIs - zero breaking changes encountered. Zero compilation errors and zero failing tests across repository. Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
…n, and CRLF - Update testdata Kptfiles to use apply-setters:v0.2.4 (was v0.2.0) which is not registered in the functions map, causing TestRender failures - Fix validateFnConfigPathSyntax to use path.IsAbs (forward-slash) instead of filepath.IsAbs so absolute path detection works correctly on all platforms - Normalize CRLF to LF in pkg_context_test.go when reading expected output files to fix TestPkgContextGenerator on Windows - Remove unused absPath helper and os import from executor_test.go Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
- Remove duplicate entries for apply-setters (v0.2.2) and krm-functions-sdk (v1.0.2) - Bump k8s.io/apiextensions-apiserver from v0.34.1 to v0.35.0 to align all k8s deps - Remove gogo/protobuf indirect dep (no longer needed) - Run go mod tidy to validate Addresses reviewer feedback on PR kptdev#4432 Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
…ility The PR bumps apply-setters to v0.2.4 in go.mod. Adding v0.2.4 to the functions registry is required so Kptfiles referencing the new version work with the built-in runner. v0.2.0 is kept for backward compatibility with existing Kptfiles that already reference that version. Also revert testdata Kptfiles back to v0.2.0 since both versions are now supported by the functions map. Addresses reviewer question on PR kptdev#4432 Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
26041d7 to
52b4935
Compare
52b4935 to
26041d7
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b55379b to
596b621
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 19 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Please rebase this PR and please fix the failing tests. |
Introduce stable v1 API for ResourceGroup while maintaining full backward compatibility with v1alpha1. Changes: - Add pkg/api/resourcegroup/v1/ with stable ResourceGroup API - Add v1/doc.go with API documentation - Add v1/types.go with ResourceGroup type and ResourceGroupGVK() - Mark v1alpha1 as deprecated with migration path - Add deprecation notices to v1alpha1 ResourceGroupGVK() Part of kptdev#4450 - API Types Stabilization Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
596b621 to
0382674
Compare
|
This PR contains dependency bumps, changes to path handling as well as adding the v1 API. Also the tests are failing. |
…-api-types Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>
5c78bf7 to
ac4b1cf
Compare
Description
This PR introduces the stable v1 API for ResourceGroup while maintaining full backward compatibility with v1alpha1. It marks v1alpha1 as deprecated and provides a clear migration path for users.
Part of #4450 - Stabilize kpt API to version 1
Changes Made
New Stable v1 API
pkg/api/resourcegroup/v1/types.gopkg/api/resourcegroup/v1/doc.goDeprecation of v1alpha1
pkg/api/resourcegroup/v1alpha1/types.goAPI Stability Guarantees
The v1 API provides the following guarantees:
Migration Path
Users can migrate from v1alpha1 to v1 by updating imports: